Skip to content

REF: dont consolidate in is_mixed_type #36873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 8, 2020
Merged

REF: dont consolidate in is_mixed_type #36873

merged 4 commits into from
Oct 8, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Avoid copies, side-effects.

jreback
jreback requested changes Oct 7, 2020
View reviewed changes
pandas/core/generic.py Outdated
# so we pretend this is "mixed'"
return True

dtypes = self.dtypes.unique()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use nunique()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated+green

@jreback jreback added the Internals Related to non-user accessible pandas implementation label Oct 7, 2020
@jreback jreback added this to the 1.2 milestone Oct 7, 2020
@jreback jreback merged commit ea98a29 into pandas-dev:master Oct 8, 2020
@jbrockmendel jbrockmendel deleted the myway-is_mixed_type branch October 8, 2020 01:25
@jorisvandenbossche jorisvandenbossche mentioned this pull request Oct 16, 2020
Merged
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
REF: dont consolidate in is_mixed_type (pandas-dev#36873)
1cddb0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback